Skip to content

fix: type constraint #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 5, 2022
Merged

fix: type constraint #188

merged 5 commits into from
Dec 5, 2022

Conversation

@aspeddro
Copy link
Collaborator

@aspeddro aspeddro commented Dec 4, 2022

Example from rescript-nodejs

type subtype<'ty> constraint 'ty = [> kind]
yarn run v1.22.19
$ /home/pedro/Desktop/projects/tree-sitter-rescript/node_modules/.bin/tree-sitter parse ../../test-filetypes/rescript_print.res
(source_file [0, 0] - [1, 0]
  (ERROR [0, 0] - [1, 0]
    (type_declaration [0, 0] - [0, 17]
      (type_identifier [0, 5] - [0, 12])
      (type_parameters [0, 12] - [0, 17]
        (type_identifier [0, 13] - [0, 16])))))
../../test-filetypes/rescript_print.res	0 ms	(ERROR [0, 0] - [1, 0])
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

aspeddro
aspeddro commented Dec 4, 2022
View reviewed changes
grammar.js
)),
repeat($.type_constraint),
)),
optional(alias($._type_declaration_and, $.type_declaration))
Copy link
Collaborator Author

@aspeddro aspeddro Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change type t and b is valid.

@nkrkv
Copy link
Collaborator

nkrkv commented Dec 5, 2022

👍

@nkrkv nkrkv merged commit d24fbeb into rescript-lang:main Dec 5, 2022
@aspeddro aspeddro deleted the fix-constraint branch December 6, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aspeddro @nkrkv